darkplaces/gmqcc
0
0
Fork 0
mirror of https://github.com/DarkPlacesEngine/gmqcc.git synced 2024-11-27 06:02:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

out-of-bounds indexing check on static array indexing

Browse source
This commit is contained in:
Wolfgang (Blub) Bumiller 2012-11-30 16:23:34 +01:00
parent 44cbf40553
commit 9f1aa1490a
1 changed files with 18 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
ast.c
View file

@ -2059,10 +2059,24 @@ bool ast_array_index_codegen(ast_array_index *self, ast_function *func, bool lva
return true;
}
if (idx->expression.vtype == TYPE_FLOAT)
*out = arr->ir_values[(int)idx->constval.vfloat];
else if (idx->expression.vtype == TYPE_INTEGER)
*out = arr->ir_values[idx->constval.vint];
if (idx->expression.vtype == TYPE_FLOAT) {
unsigned int arridx = idx->constval.vfloat;
if (arridx >= self->array->expression.count)
{
compile_error(ast_ctx(self), "array index out of bounds: %i", arridx);
return false;
}
*out = arr->ir_values[arridx];
}
else if (idx->expression.vtype == TYPE_INTEGER) {
unsigned int arridx = idx->constval.vint;
if (arridx >= self->array->expression.count)
{
compile_error(ast_ctx(self), "array index out of bounds: %i", arridx);
return false;
}
*out = arr->ir_values[arridx];
}
else {
compile_error(ast_ctx(self), "array indexing here needs an integer constant");
return false;