darkplaces/gmqcc
0
0
Fork 0
mirror of https://github.com/DarkPlacesEngine/gmqcc.git synced 2025-02-17 09:02:25 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix possible NULL pointer dereference

Browse source
This commit is contained in:
Dale Weiler 2013-06-21 23:21:12 +00:00
parent 125d039e3d
commit 996d998ebb
1 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
ast.c
View file

@ -1152,16 +1152,15 @@ ast_function* ast_function_new(lex_ctx ctx, const char *name, ast_value *vtype)
{
ast_instantiate(ast_function, ctx, ast_function_delete);
if (!vtype ||
vtype->hasvalue ||
vtype->expression.vtype != TYPE_FUNCTION)
{
if (!vtype) {
compile_error(ast_ctx(self), "internal error: ast_function_new condition 0");
goto cleanup;
} else if (vtype->hasvalue || vtype->expression.vtype != TYPE_FUNCTION) {
compile_error(ast_ctx(self), "internal error: ast_function_new condition %i %i type=%i (probably 2 bodies?)",
(int)!vtype,
(int)vtype->hasvalue,
vtype->expression.vtype);
mem_d(self);
return NULL;
goto cleanup;
}
self->vtype = vtype;
@ -1186,6 +1185,10 @@ ast_function* ast_function_new(lex_ctx ctx, const char *name, ast_value *vtype)
self->return_value = NULL;
return self;
cleanup:
mem_d(self);
return NULL;
}
void ast_function_delete(ast_function *self)